chore: Rust checks are required + merge queue#21941
Merged
comphead merged 1 commit intoapache:mainfrom May 6, 2026
Merged
Conversation
blaginin
commented
Apr 29, 2026
Comment on lines
-36
to
-40
| paths-ignore: | ||
| - "docs/**" | ||
| - "**.md" | ||
| - ".github/ISSUE_TEMPLATE/**" | ||
| - ".github/pull_request_template.md" |
Member
Author
There was a problem hiding this comment.
a bit annoying that we'll run those on every pr even on those that changes docs. but:
- we don't have many of those anyway
- i really tried to fix this, but it makes the CI very complicated to install and support in the future
github-actions
Bot
added
the
development-process
Member
Author
|
Now it will take 2x16 minutes to perform a merge (16 mins to put the PR in the queue + 16 mins to merge in the queue). I think that's OK since it's all automated. But we can actually make it MUCH faster - 2x6 mins instead. 
You can see that the actual bottleneck is the Mac OS tests - that's because runs-on doesn't support them. My ideas:
|
comphead
changed the title
Contributor
|
thanks @blaginin the execution takes nothing but planning might take something, 14 entries for linux tests and 20 for macos |
Member
Author
|
thanks! @comphead
|
Contributor
|
woogoo! |
Member
Author
noticed that, will clean up now |
Member
Author
|
actually, it's actually expected - since the required checks became required AFTER we merged this PR, so the new ones should be working correctly! |
diegoQuinas
pushed a commit
to diegoQuinas/datafusion
that referenced
this pull request
May 6, 2026
apache#22048) Follow up apache#21941 The macos-aarch64 job took ~22 min - 68% compile, 25% test. An audit of macos-only PR failures over Mar-May 2026 (1000 failed PR runs, 30 with macOS as the sole signal) found that nearly all the unique signal was either: - flaky sqllogictest metrics (~67%, e.g. push_down_filter / explain_analyze .slt files with platform-dependent scan_efficiency_ratio numbers), - real bugs in datafusion-benchmarks (which amd64 was excluding), or - one genuinely macOS-specific FFI cdylib loading bug (datafusion/ffi/src/tests/utils.rs path resolution). So the only thing macOS uniquely catches is FFI dylib loading. Scope the macOS job down to `cargo test -p datafusion-ffi --features integration-tests` and let amd64 pick up the datafusion-benchmarks coverage that was being dropped by the linux-test --exclude list. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6880
Follow up on #17538 and #21239
#21239 seems to be working fine - time to make all the rust changes required to merge it.
This brings two cool things:
You can click this button any time, even right after opening a PR. It will be automatically merged when:
I think this should help quite a bit. A lot of people get an approval, push a nit, and then sit waiting for CI to finish. No more waiting!!
One downside: before, clicking merge would happen instantly (although you had manually to wait for tests to be green). With this PR, you won't have to wait, but it will take 16 minutes to merge (plus, 16 more to put in the merge queue if you just pushed). But github will do the work itself and ensure tests are passing on the latest
main.